Rust port #8
Open
Rust port #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
force-pushed
the
main
branch
3 times, most recently
from
b96a005
to
60c8ce3
Compare
Closed
|
Tests now pass locally 🚀 |
|
However fwiw this still doesn't yet support Numpy v2. But that should be soon! Ref PyO3/rust-numpy#429 (comment) and PyO3/rust-numpy#409. The polars people are in that thread pushing as well |
There was a problem hiding this comment.
Can also be deleted; was a way for me to look at the cython source locally after moving the rust code to the top level
There was a problem hiding this comment.
why do we need this in /rust dir ?
There was a problem hiding this comment.
Oh that's from the earlier version of this branch where the rust version was separate, and it can be deleted
|
@kylebarron I trust you on the overall PR. My two complains are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just for visibility 🙂, not for merge